Bugfixes

[camelotcrusade]

Up next - 1. Does anyone have ideas of where to even begin to fix the Crystal Collector bug? That one is really cramping my style. Yeah, I know I'm only missing out on a few points of intellect, but I know if I start spending my crystals it will be ages before I catch up.

2. I've never seen my alchemist or my engineer mix more than one bottle when using their remix ability. Here's what the code says (line 3026, unit_special_attacks.lua):

-- ***********************************************
-- Ñîçäàíèå Çåëèé/Ãðàíàò (Àëõèìèê, Èíæåíåð)
-- ***********************************************
function special_craft_attack()
  local charge = 1
  if Attack.act_human(0) then
    if Attack.act_name(0) == "alchemist" then
      if Logic.hero_lu_item_on_body("alchemist_toolkit") then
        if 10 >= Game.CurLocRand(1, 100) then
          charge = charge + 1
        end
      end
    end
  end

  local animation = Attack.get_custom_param("animation")
  Attack.act_aseq(0, animation)
  local dmgts = Attack.aseq_time(0, "x")
  local name = Attack.get_custom_param("craft")
  local craft_name = "craft_"..name
  Attack.act_enable_attack(0, craft_name, false)
  Attack.act_enable_attack(0, name, true)
  Attack.act_charge(0, charge, name)

  local size = Attack.act_size(0)
  if Attack.act_size(0)> 2 then
    size = 2
  end
  Attack.log(0.5 + dmgts, "add_blog_chemistry_crafting_success_"..tostring(charge)..tostring(size), "name", blog_side_unit(0, 0), "special", charge)

  return true
end

I can see it looks like there is a 10% chance to do better than 1 bottle. Have I just been unlucky 20+ times or might there be something wrong here?

[namad]

1) the powerful raise ability is intentionally limited to the recent past... as a balancing factor... its still prolly op!

2) what does the witchhunter fix actually do? (I didn't know what was wrong with them before)


also... is 20intiative rune mages a bug? what should it be? is that fixable via lua? what was it in crossworlds? 20 seems like its gotta be a typo? 20 is prolly the max possible value or something?

[Bhruic]

Originally Posted by namad

2) what does the witchhunter fix actually do? (I didn't know what was wrong with them before)

Their self-buff ability was limited to only giving them the Dragonslayer buff. With the fix, they are back to potentially getting any of the buffs in their repertoire.

also... is 20intiative rune mages a bug? what should it be? is that fixable via lua? what was it in crossworlds? 20 seems like its gotta be a typo? 20 is prolly the max possible value or something?

It's hard to say if it's a bug or not, but it seems unlikely to be a typo (I doubt they intended to give them 2 initiative, and even 10 would seem high).

[camelotcrusade]

Originally Posted by namad

1) the powerful raise ability is intentionally limited to the recent past... as a balancing factor... its still prolly op!

I am starting to agree it's working as intended. What it should say is "Restores a maximum of X forces of the targeted troop if they receive the Call of Valhalla before they act again." That's what it really does, and I agree that's plenty good.

I'm going to move it to the description/tooltip section.

[tikitoki]

Originally Posted by namad

1) the powerful raise ability is intentionally limited to the recent past... as a balancing factor... its still prolly op!

2) what does the witchhunter fix actually do? (I didn't know what was wrong with them before)


also... is 20intiative rune mages a bug? what should it be? is that fixable via lua? what was it in crossworlds? 20 seems like its gotta be a typo? 20 is prolly the max possible value or something?

Its BUGGED! Why? Cause los of times I cant revive my fallen soldiers next turn. Its clearly says you can use this ability for soldiers fallen in last TWO rounds and sometimes I can "call them back" the next turn, sometimes not.

I think it might have something to do with extra moves due to luck runes or something like that and game counts those as ROUNDS and that is simply bugged as using that skill becomes like a gamble and its pretty annoying.

Otherwise I agree, this is one seriously overpowered skill. Especialy combined with soem other skills.

[ckdamascus]

Originally Posted by tikitoki

Its BUGGED! Why? Cause los of times I cant revive my fallen soldiers next turn. Its clearly says you can use this ability for soldiers fallen in last TWO rounds and sometimes I can "call them back" the next turn, sometimes not.

I think it might have something to do with extra moves due to luck runes or something like that and game counts those as ROUNDS and that is simply bugged as using that skill becomes like a gamble and its pretty annoying.

Otherwise I agree, this is one seriously overpowered skill. Especialy combined with soem other skills.

Well, not really bugged. Just bad description. If you raise a fallen unit via Maiden, you can't re-raise them again until 2 turns pass again.

So, if you raise, then lose units next turn, they are lost forever (at least with this skill).

[Nirual]

Originally Posted by ckdamascus

Well, not really bugged. Just bad description. If you raise a fallen unit via Maiden, you can't re-raise them again until 2 turns pass again.

So, if you raise, then lose units next turn, they are lost forever (at least with this skill).

It also seems that if you use other means of raising troops, they are removed from the "pool" of losses that the Maiden can ressurect, even if the troop lost more earlier than those two turns.

[ftww]

With regard to this bug:

Pygmy reduces to 1 HP: Build 6249. Pygmy reduces the health of enemy stacks to 1 HP per unit instead of -20%/-30%/-40% of their max health.

Does the following look like the right fix? In spells.lua, line 2446:

Attack.act_apply_par_spell( "health", -bhealth*penalty, 0, 0, -100, false)

Change to:

Attack.act_apply_par_spell( "health", -bhealth*penalty/100, 0, 0, -100, false)

[ckdamascus]

Originally Posted by ftww

With regard to this bug:


Does the following look like the right fix? In spells.lua, line 2446:

Attack.act_apply_par_spell( "health", -bhealth*penalty, 0, 0, -100, false)

Change to:

Attack.act_apply_par_spell( "health", -bhealth*penalty/100, 0, 0, -100, false)

Yes, this looks like it works!!!

Thanks! I'm going to try to figure out avenging angel now... haha!

I think I found the problem with avenging angel, but it almost seems like it was intentional. Was it a buff to avenging angel then? Unfortunately, the Favorite of the Gods thing is tied to Avenging Angel.

I can revert it back to the old behavior hmmm.

Doesn't look like I can fix Demon Rage Ball or Evil Book since they seem to call functions outside of the .lua files? How does that work? Also, Shroud / aka Oil Mist aka Greasy Mist looks heavily re-worked with different parameters going in. So it is probably changed too heavily for me to safely adjust. Just going for the low hanging fruit now!


CODE FIX for AVENGING ANGEL and FAVORITE OF THE GODS
In spells.lua, line 745:

  elseif minmax == 0 then
    Attack.act_posthitslave(receiver, "post_spell_slave_angel_avenger", 0)
  end
  return 1,1--damage, addrage
end

  elseif minmax == 0 then
    Attack.act_posthitslave(receiver, "post_spell_slave_angel_avenger", 0)
  end
  return damage, addrage
end

[Nirual]

Originally Posted by ckdamascus

Yes, this looks like it works!!!

Thanks! I'm going to try to figure out avenging angel now... haha!

I think I found the problem with avenging angel, but it almost seems like it was intentional. Was it a buff to avenging angel then? Unfortunately, the Favorite of the Gods thing is tied to Avenging Angel.

I really don't think AA needed a buff. And if Beloved by the Gods is affected by the same change, it seems to be calculated separately since troops can take 1 dmg without the damage return and vice-versa.

Also, your code fix seems to also disable rage gain from the avenging angel, ( addrage), which I don't think is part of the problem.