Bugfixes

[QNk]

       if receiver_human and not receiver_glot and (skill_power("weakness_lore", 2) > 0) then
          kritProb = kritProb - skill_power("weakness_lore", 2)
          if kritProbRnd < kritProb then
            iskrit = true
          else
            is_weakness_lore = true

Doesn't the iskrit check also need to be changed to true? What it's doing right now is if a crit is registered, it checks again against a kritProb modified by sense weakness. If iskrit = false, then the game would only register a crit if the random number was LOWER than the initial but HIGHER than the modified kritProb. Or did I misunderstand how the kritProbRnd < kritProb inequality work?

[Bhruic]

Originally Posted by QNk

Doesn't the iskrit check also need to be changed to true? What it's doing right now is if a crit is registered, it checks again against a kritProb modified by sense weakness. If iskrit = false, then the game would only register a crit if the random number was LOWER than the initial but HIGHER than the modified kritProb. Or did I misunderstand how the kritProbRnd < kritProb inequality work?

iskrit is already set to true to begin with, that's the only way to enter that code block (with the "if iskrit then"). So there's no need to do anything to it unless Sense Weakness kicks in, in which case it needs to be set to false.

[Bhruic]

Ok, I changed the Sense Weakness fix to Zechnophobe's solution, as it's simpler (I give up! )

Added a second fix for Sense Weakness (effect was being applied twice).

Added a fix for spells/rage not getting critical hits.

[Bunnle]

edit: wrong topic, my bad.

[Csimbi]

@Bhruic
There's no version number on the zip file in the first post.
Is that the latest (as of today)?
Maybe you could add the date to the filename in the future.
Thanks!

Just reported this bug (you might want to consider adding this, too):
"Guardian" award - While the hint appearing above this award says that this award gives resistance to all types of damage, it actually does not give any resistance to 'glacial' and 'astral' damage.
It was fixed in my extended awards mod. Those that want the fix without the modifications can apply the same fix by looking at the included medals.txt.

[xtrm]

Thanks, the fixes work nice and no more crashes in battles

[ikbenrichard]

Hi Bhruic,

can you remove the fix: LAST HERO, from your subpatch? Since its fixed with the steam patch.

[Bhruic]

There are lots of bugs officially fixed in the latest patch, I'm going to need to go through each fix individually to see if it still applies. That'll take a bit of time.

[ikbenrichard]

Originally Posted by Bhruic

There are lots of bugs officially fixed in the latest patch, I'm going to need to go through each fix individually to see if it still applies. That'll take a bit of time.

I understand, I (we) greatly appreciate your efforts !!

[camelotcrusade]

Let me know if you need help.

Question: What do we need to do if we all the fixes to date installed? Clear the addon folder and start fresh? Otherwise, won't it read our files before the patched files?

I know I am going to want to put some of our stuff back in, too, especially where I like some of our fixes better.