Bugfixes

[webfischi]

It looks like I'm the first who was able to catch that bug. When you attack, the damage is indefinite (zero).

The code for this mask is in arena.lua line 859-884 and looks like this:

  -- маска Зависти
	if hero_item_count2("sp_bonus_level_damage", "count") > 0 then
		if attacker ~= nil and receiver ~= nil and damage > 0 then
			local atk_level = Attack.act_level(attacker)
			if Attack.act_feature(attaker,"pawn") then 
				atk_level = 3
				if Attack.act_feature(attaker,"boss") then
					atk_level = 5
				end
			end
			
			local rec_level = Attack.act_level(receiver)
			if Attack.act_feature(receiver,"pawn") then 
				rec_level = 3
				if Attack.act_feature(receiver,"boss") then
					rec_level = 5
				end
			end
			
			if atk_level > rec_level then
				damage = damage * (1 + (atk_level - rec_level) * hero_item_count2("sp_bonus_level_damage", "count")/100)
				addrage = addrage * (1 + (atk_level - rec_level) * hero_item_count2("sp_bonus_level_damage", "count")/100)
			end
			
		end
	end

Edit: After further investigation, the game doesn't get anything from the "damage" equation, I added a line that should set damage to 1 no matter what solution was calculated earlier, and the game still says 0, so I guess it is missing some kind of return value.

[Csimbi]

Originally Posted by webfischi

It looks like I'm the first who was able to catch that bug. When you attack, the damage is indefinite (zero).

I would not say it's indefinite.
The damage never yields 0 (unless damage was <= 0 to begin with), but yes, it does yield 0 damage bonus in most cases.
Item allows wearer to hit weaker enemies with increased damage.
So, I think that's the idea.
That said, it looks ok to me.

[webfischi]

I'll add a savegame to try and investigate, because every attack in this example will be zero.

[webfischi]

Just found out how to enable dev mode with the Steam version, and the debugger seems to be unhappy with "nil" in line 861, so there is the main issue. Now I am pretty sure they never playtested the DLC when the game is screeming at me, that this is wrong.

[clim77]

Originally Posted by webfischi

Just found out how to enable dev mode with the Steam version, and the debugger seems to be unhappy with "nil" in line 861, so there is the main issue. Now I am pretty sure they never playtested the DLC when the game is screeming at me, that this is wrong.

Hi, webfischi, can you explain how to enable dev mode, please? Thanks!

[Space Knight]

Originally Posted by clim77

Hi, webfischi, can you explain how to enable dev mode, please? Thanks!

So, first, make sure you have a shortcut to the game on your desktop. After that, right-click and press properties. After \kb.exe" section in Target, add " -dev", like this: \kb.exe" -dev (don't put comas after dev). Now, press Apply and then Ok. You can now play in dev mode by starting the game from the shortcut.

[webfischi]

Right click your King's Bounty game in your steam library, Properties, Set Launch Options and type "-dev" without quotes of course. This starts the game in dev mode not just from a short cut.

[zelurker]

I wouldn't have believed this topic was still active after so many years !
Now maybe it would be a good idea to have some kind of central repository for the fixes which can still be useful, like github although these kfs files would not be very convenient for git, but it's worth trying to setup something, most links in these pages are dead now, only the code directly displayed or the attached files are still usable...