Bugs Thread

[Bhruic]

Originally Posted by camelotcrusade

Added Suicidal Dwarven Statue to units

As an addition to that - suicidal units. For some reason they upped the target priority of the various statues/etc, which is fine in general, but melee units seem to have an unhealthy (for them) desire to run up and whack exploding barrels. Which explode. In their face.

[camelotcrusade]

Originally Posted by Bhruic

As an addition to that - suicidal units. For some reason they upped the target priority of the various statues/etc, which is fine in general, but melee units seem to have an unhealthy (for them) desire to run up and whack exploding barrels. Which explode. In their face.

ROFL. I'll add that plus a few more quests I found. I'm almost afraid to come to the forums after I wake up, there goes an hour listing all the new bugs.

At least I have exciting bug fixes to look forward to!

[pr0]

As an update for the mind skill sense weakness I have now taken tier 2 and tier 3 with the same viking units:

Warrior Maiden, Berzerker, Jarl, Axe thrower, Soothsayer.

Lvl 1 gives a universal +6% critical, Lvl 2 gives nothing and level 3 gave Warrior Maidens and Axe Throwers +2% critical chance and everything else +3%. I initially thought that it increased the percentage dependent on the units base crit rating but soothsayers went from 20% crit to 23% whilst axe throwers went from 24% to 26% as did Warrior Maidens.

So now I am officially confused - and have 22 mind runes to use

[camelotcrusade]

Originally Posted by pr0

As an update for the mind skill sense weakness I have now taken tier 2 and tier 3 with the same viking units:

Warrior Maiden, Berzerker, Jarl, Axe thrower, Soothsayer.

Lvl 1 gives a universal +6% critical, Lvl 2 gives nothing and level 3 gave Warrior Maidens and Axe Throwers +2% critical chance and everything else +3%. I initially thought that it increased the percentage dependent on the units base crit rating but soothsayers went from 20% crit to 23% whilst axe throwers went from 24% to 26% as did Warrior Maidens.

So now I am officially confused - and have 22 mind runes to use

Don't forget, this skill is also causing random recovery from rage and other weirdness. Do any code hawks have time to crack this open? In the mean time I will list it.

[Bhruic]

Originally Posted by pr0

As an update for the mind skill sense weakness I have now taken tier 2 and tier 3 with the same viking units:

Warrior Maiden, Berzerker, Jarl, Axe thrower, Soothsayer.

Lvl 1 gives a universal +6% critical, Lvl 2 gives nothing and level 3 gave Warrior Maidens and Axe Throwers +2% critical chance and everything else +3%. I initially thought that it increased the percentage dependent on the units base crit rating but soothsayers went from 20% crit to 23% whilst axe throwers went from 24% to 26% as did Warrior Maidens.

So now I am officially confused - and have 22 mind runes to use

I'm trying really hard to figure out what "espace" means... *sigh* They really did a horrible job with some of these tooltips.

Anyway, the numbers don't make a lot of sense. There seems to be a typo based on the tooltip, as the level 2 has a -5% where the other two levels have a 3% and 7% respectively. But that doesn't explain how it's messing up the numbers.

edit: Ah, I found the problem. In skills.txt:

levels {
      1 {
        deps=1
        runes=0,11,1
        trade=
        pars=+3%,3%
        fight {
          {
            filter {
              belligerent=ally
            }
            pbonus=krit,5,0,0,-100,0,0
          }
        }
      }
      2 {
        deps=1
        runes=0,11,1
        trade=
        pars=+5%,-5%
        fight {
          {
            filter {
              belligerent=ally
            }
            pbonus=krit,5,0,0,-100,0,0
          }
        }
      }
      3 {
        deps=1
        runes=0,11,1
        trade=
        pars=+7%,7%
        fight {
          {
            filter {
              belligerent=ally
            }
            pbonus=krit,7,0,0,-100,0,0
          }
        }
      }
    }

The "pbonus" part is what's relevant here, it goes 5, 5, 7 for the 3 levels.

There's something "extra" going on with vikings, as they seem to get different bonuses than other things do. The animals I checked with all got the +5% for the first level that it indicates they should, but the vikings seemed to get +6%. Not sure where the extra 1% comes from. Also not sure what the pars=3%,3% etc, is supposed to be doing.

[DeRex]

Traveling between any islands consumes one whole day always, not just few hours.

[DGDobrev]

Well, it was the same in KBTL. There was also a mechanic in KBTL when if you wait for the right moment in time (before the day rolls over to next one) you can travel in like an hour or so. I wonder if the same thing can be used here.

[camelotcrusade]

Originally Posted by DGDobrev

Well, it was the same in KBTL. There was also a mechanic in KBTL when if you wait for the right moment in time (before the day rolls over to next one) you can travel in like an hour or so. I wonder if the same thing can be used here.

Do you guys think I should list it as a bug then? The game does suggest it should be hours and not days. And does it even matter for anything besides spell point regen and rage loss? I don't recall if there is a score for speed or not.

[QNk]

Originally Posted by Bhruic

There's something "extra" going on with vikings, as they seem to get different bonuses than other things do. The animals I checked with all got the +5% for the first level that it indicates they should, but the vikings seemed to get +6%. Not sure where the extra 1% comes from. Also not sure what the pars=3%,3% etc, is supposed to be doing.

Pars (parameters) are what the language and mechanics files pull to do calcumalations. It goes Pars=[param1],[param2],[param3], so on and so forth. The localization files (eng_skills.lng for most of us) pull these directly as [param#]. For example, level 1 of Sense Weakness has the following description (I think I reworded this one to make more sense, so don't expect it to match yours).

skill_weakness_lore_text_1=^skills_tPar^Troops. Chance of allies inflicting a critical hit [param1]. <br>Chance of allies to escape a critical hit [param2].

In game, where [param1] is supposed to be will instead display the number in the pars list.

In mechanics files these values are referenced using name of the skill, followed by a single number for which param to pull. For example, the diplomacy skill power calculation pulls the first param listed via the following (in skills.lua)

local perc_pacify = skill_power("diplomacy", 1)

This defines the local variable "perc_pacify" by pulling the first param listed in Diplomacy's pars list. This variable is then used for fancy mathematics further down the line.

Consistency is awesome, this usually(!) allows a modder to modify only the skills.txt file to have the change effected in both description as well as calculations.

EDIT: Also, some calculations are super simple to do (like adding a fixed percentage to critical chance, or increasing morale of certain troops by one), these are written directly in the skills.txt file. So changing the pars of these won't affect actual values ingame unless you also change the values in the pbonus (parameter bonus), rbonus (resistance bonus), or dbonus (not sure...) lines.