Bugfixes

[ftww]

With regard to this bug:

Pygmy reduces to 1 HP: Build 6249. Pygmy reduces the health of enemy stacks to 1 HP per unit instead of -20%/-30%/-40% of their max health.

Does the following look like the right fix? In spells.lua, line 2446:

Attack.act_apply_par_spell( "health", -bhealth*penalty, 0, 0, -100, false)

Change to:

Attack.act_apply_par_spell( "health", -bhealth*penalty/100, 0, 0, -100, false)

[ckdamascus]

Originally Posted by ftww

With regard to this bug:


Does the following look like the right fix? In spells.lua, line 2446:

Attack.act_apply_par_spell( "health", -bhealth*penalty, 0, 0, -100, false)

Change to:

Attack.act_apply_par_spell( "health", -bhealth*penalty/100, 0, 0, -100, false)

Yes, this looks like it works!!!

Thanks! I'm going to try to figure out avenging angel now... haha!

I think I found the problem with avenging angel, but it almost seems like it was intentional. Was it a buff to avenging angel then? Unfortunately, the Favorite of the Gods thing is tied to Avenging Angel.

I can revert it back to the old behavior hmmm.

Doesn't look like I can fix Demon Rage Ball or Evil Book since they seem to call functions outside of the .lua files? How does that work? Also, Shroud / aka Oil Mist aka Greasy Mist looks heavily re-worked with different parameters going in. So it is probably changed too heavily for me to safely adjust. Just going for the low hanging fruit now!


CODE FIX for AVENGING ANGEL and FAVORITE OF THE GODS
In spells.lua, line 745:

  elseif minmax == 0 then
    Attack.act_posthitslave(receiver, "post_spell_slave_angel_avenger", 0)
  end
  return 1,1--damage, addrage
end

  elseif minmax == 0 then
    Attack.act_posthitslave(receiver, "post_spell_slave_angel_avenger", 0)
  end
  return damage, addrage
end

[Nirual]

Originally Posted by ckdamascus

Yes, this looks like it works!!!

Thanks! I'm going to try to figure out avenging angel now... haha!

I think I found the problem with avenging angel, but it almost seems like it was intentional. Was it a buff to avenging angel then? Unfortunately, the Favorite of the Gods thing is tied to Avenging Angel.

I really don't think AA needed a buff. And if Beloved by the Gods is affected by the same change, it seems to be calculated separately since troops can take 1 dmg without the damage return and vice-versa.

Also, your code fix seems to also disable rage gain from the avenging angel, ( addrage), which I don't think is part of the problem.

[ckdamascus]

Originally Posted by Nirual

I really don't think AA needed a buff. And if Beloved by the Gods is affected by the same change, it seems to be calculated separately since troops can take 1 dmg without the damage return and vice-versa.

Also, your code fix seems to also disable rage gain from the avenging angel, ( addrage), which I don't think is part of the problem.

Maybe just try damage, addrage.
What boggles me beyond belief is, that code was there but commented out.

1,1, -- damage, addrage.

I suppose maybe just revert it to that instead? Last minute debug stuck in there?

[Mickelangello]

Do you have any idea what to do if i have non-steam version? There are no .lua files...

[ckdamascus]

Originally Posted by Mickelangello

Do you have any idea what to do if i have non-steam version? There are no .lua files...

Steam/non-steam, same thing. What happens is in the sessions/addon folder there is a ses.kfs file. That's really just a renamed zip file. I'd make a backup of that file, rename to .zip, exact all files.

Furthermore, if you just drop a .lua file in sessions/addon it OVERRIDES whatever is in the ses.kfs file.

So just exact, modified .lua, copy .lua there.

Be careful, if there is ever an official patch, you have to remove the old .lua file since the .lua file overrides whatever is in the official ses.kfs.