Quote:
Originally Posted by Bhruic
That'd involve less steps, certainly. I think mine's slightly more elegant in that it requires less steps if you don't have Sense Weakness. Of course, I might be biased.  |
Hmm, just for the sake of discussion...
I wasn't optimizing for speed, since that is no doubt a non-issue with something like this. More just for how clarity and ease of debugging. Calling in additional functions to do your logic like that makes the code slightly weightier. And then, any edit to an external source should generally be simple so as a diff is easy to understand. Seeing:
Code:
Blah blah < bleh bleh
Turn into
Code:
Blah blah >= bleh bleh
Is pretty clear what the problem was, and the solution for it.
Er, not that any of this really matters... I've just been doing code reviews at work recently and it has me thinking about Ivory Tower code production stuff.